feat(modern-js-plugin-v3): port RSC bridge support into core#4467
Open
ScriptedAlchemy wants to merge 31 commits intomainfrom
Open
feat(modern-js-plugin-v3): port RSC bridge support into core#4467ScriptedAlchemy wants to merge 31 commits intomainfrom
ScriptedAlchemy wants to merge 31 commits intomainfrom
Conversation
Port the modernjs-v3 RSC bridge runtime, async startup loader, and config/SSR wiring into core. Add parity tests plus static middleware hardening for stable manifest serving and action routing. Co-authored-by: Cursor <cursoragent@cursor.com>
🦋 Changeset detectedLatest commit: a317b3f The changes in this PR will be included in the next version bump. This PR includes changesets to release 46 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for module-federation-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Co-authored-by: Cursor <cursoragent@cursor.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ede7e89a78
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Comment on lines
+765
to
+769
| chain.resolve.conditionNames | ||
| .clear() | ||
| .add('require') | ||
| .add('import') | ||
| .add('default'); |
There was a problem hiding this comment.
patchBundlerConfig currently clears chain.resolve.conditionNames for every server RSC build and re-adds only require/import/default. That drops existing server conditions (notably node), so packages that use conditional exports can resolve to non-Node entries in SSR (for example falling back to default/browser builds), which can break runtime behavior as soon as such a dependency is present. Keep the existing condition set and append react-server instead of resetting the list.
Useful? React with 👍 / 👎.
Comment on lines
+51
to
+54
| runBundle( | ||
| localModule.exports, | ||
| require, | ||
| localModule, |
There was a problem hiding this comment.
The VM wrapper is invoked with this module's require, not a require bound to filepath. If the async-startup bundle (or its runtime chunk loader) performs relative imports like require('./<chunk>.js'), resolution happens relative to asyncStartupLoader.ts and fails with MODULE_NOT_FOUND, causing the strategy to return undefined and leaving async-startup bundles uninitialized. Use a filepath-scoped loader (e.g. module.createRequire(filepath)) when calling runBundle.
Useful? React with 👍 / 👎.
@module-federation/devtools
@module-federation/cli
create-module-federation
@module-federation/data-prefetch
@module-federation/dts-plugin
@module-federation/enhanced
@module-federation/error-codes
@module-federation/esbuild
@module-federation/managers
@module-federation/manifest
@module-federation/metro
@module-federation/metro-plugin-rnc-cli
@module-federation/metro-plugin-rnef
@module-federation/modern-js
@module-federation/modern-js-v3
@module-federation/native-federation-tests
@module-federation/native-federation-typescript
@module-federation/nextjs-mf
@module-federation/node
@module-federation/retry-plugin
@module-federation/rsbuild-plugin
@module-federation/rspack
@module-federation/rspress-plugin
@module-federation/runtime
@module-federation/runtime-core
@module-federation/runtime-tools
@module-federation/sdk
@module-federation/storybook-addon
@module-federation/third-party-dts-extractor
@module-federation/treeshake-frontend
@module-federation/treeshake-server
@module-federation/typescript
@module-federation/utilities
@module-federation/webpack-bundler-runtime
@module-federation/bridge-react
@module-federation/bridge-react-webpack-plugin
@module-federation/bridge-shared
@module-federation/bridge-vue3
@module-federation/inject-external-runtime-core-plugin
commit: |
Contributor
Bundle Size Report11 package(s) changed, 30 unchanged.
Total dist: 6.75 MB (+384.2 kB (+5.9%)) |
Align server-side RSC bridge resolution and dev asset serving with pre-move modern.js behavior. This prevents host SSR from loading browser remote entries and unblocks dev/build rsc-mf flows. Co-authored-by: Cursor <cursoragent@cursor.com>
Member
|
Can you help add the modernjs rsc example to apps dir ? |
Append react-server without clearing existing resolve conditions. Use bundle-scoped require for async-startup VM execution. Add a minimal ModernJS RSC example app under apps. Co-authored-by: Cursor <cursoragent@cursor.com>
Update pnpm-lock.yaml to match branch manifests. This restores frozen-lockfile installs in CI and Netlify preview builds. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # pnpm-lock.yaml
Resolve the dts-plugin TYPE-001 failure by correcting package entry paths for workspace dependencies and updating RawSource usage for webpack typings. Co-authored-by: Cursor <cursoragent@cursor.com>
Restore sdk and error-codes export paths to the filenames emitted by the current build so CI package resolution no longer fails on these branches. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: zhouxiao.shaw <zhouxiao.shaw@bytedance.com>
# Conflicts: # packages/dts-plugin/src/core/lib/typeScriptCompiler.ts # packages/error-codes/package.json # packages/modernjs-v3/src/cli/configPlugin.ts # packages/rspack/src/ModuleFederationPlugin.ts # pnpm-lock.yaml
# Conflicts: # pnpm-lock.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rsc-bridge-runtime-plugin,rsc-bridge-expose, and client callback bootstrap wiring@modern-js/server-core/nodestrategy registration for compatibility with published server-core typespackages/modernjs-v3Test plan
npx nx format:checknpx nx run modern-js-plugin-v3:testnpx nx run modern-js-plugin-v3:buildnpx nx run-many --targets=build --projects=tag:type:pkg --parallel=4npx nx affected -t test --parallel=3 --exclude='*,!tag:type:pkg'npx nx run-many --targets=build --projects=tag:type:pkg --parallel=4 --skip-nx-cache --exclude=chrome-devtoolsnpx nx run-many --targets=build --projects=tag:type:pkg --parallel=4 --skip-nx-cache(fails on unrelatedchrome-devtools:buildTS2305 for@module-federation/sdkexports)Made with Cursor